Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dpi in tracks #292

Open
wants to merge 10 commits into
base: dev_api
Choose a base branch
from

Conversation

lldelisle
Copy link
Collaborator

Hi,
(This PR has been built on top of abstract_classes this is why there are so many changes.)

The idea of this PR is to remove the need of DPI inside the plot_label method of each track class to be able to save an image in different resolution through API.
While I was doing this PR I noticed that the figures had pretty large margin on left and right and that both 'titles' and 'y-axis' were in fact printed in the margin:
master_hlines

When I removed DPI from the tracks, I forced the labels (titles) to fit in the axis:
master_hlines

Should we also make the 'y-axis' fit into its axis or do we leave it go to the margin.

Of course, as you can notice, this PR will change the proportion each column relative to the page so I need to update all outputs used in tests but before doing it I wanted to see with you the 'y-axis' and decide together the left and right margins.

@joachimwolff
Copy link
Collaborator

How will the result look if you force the y-axis labels?

@lldelisle
Copy link
Collaborator Author

We cannot really force the 'y-axis' because nothing is preventing matplotlib to write outside of the figure but with some changes in the code we could have:
master_arcs_no_score
master_hlines
But if you have very high values:
master_hlines2
The thing we could do is like we do for --trackLabelFraction, have a --yAxisFraction which would give:
master_hlines2
When set to 0.1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants