Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
(This PR has been built on top of abstract_classes this is why there are so many changes.)
The idea of this PR is to remove the need of DPI inside the
plot_label
method of each track class to be able to save an image in different resolution through API.While I was doing this PR I noticed that the figures had pretty large margin on left and right and that both 'titles' and 'y-axis' were in fact printed in the margin:
When I removed DPI from the tracks, I forced the labels (titles) to fit in the axis:
Should we also make the 'y-axis' fit into its axis or do we leave it go to the margin.
Of course, as you can notice, this PR will change the proportion each column relative to the page so I need to update all outputs used in tests but before doing it I wanted to see with you the 'y-axis' and decide together the left and right margins.