feat: keep3r sponsor #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into keep3rSponsor
0xShaito
suggested changes
Apr 11, 2024
| address(keep3rHelper), abi.encodeWithSelector(IKeep3rHelper.getRewardAmountFor.selector), abi.encode(_reward) | ||
| ); | ||
|
|
||
| uint256 rewardWithBonus = (_reward * keep3rSponsor.bonus()) / keep3rSponsor.BASE(); |
|
|
||
| /// @inheritdoc IKeep3rSponsor | ||
| function setBonus(uint256 _bonus) external onlyOwner { | ||
| bonus = _bonus; |
There was a problem hiding this comment.
Add a check. Can't be lower than 10_000
| if (!_isKeeper) revert Keep3rSponsor_NotKeeper(); | ||
| uint256 _initialGas = gasleft(); | ||
|
|
||
| for (uint256 _i; _i < _execData.length;) { |
There was a problem hiding this comment.
Maybe move this up a line so we don't include this check as payment for the keeper
0xShaito
approved these changes
Apr 15, 2024
| import {IKeep3rV2} from '../../interfaces/external/IKeep3rV2.sol'; | ||
| import {IKeep3rHelper} from '../../interfaces/external/IKeep3rHelper.sol'; | ||
| import {IKeep3rV1} from '../../interfaces/external/IKeep3rV1.sol'; | ||
| import {IKeep3rBondedRelay} from '../../interfaces/relays/IKeep3rBondedRelay.sol'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.