Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error handling while calling the COMA.jar #69

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

kPsarakis
Copy link
Member

Correctly catch errors thrown from Java in the Coma algorithm, raised in #58

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3f8a9e5) 86.44% compared to head (4fe189e) 86.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   86.44%   86.36%   -0.09%     
==========================================
  Files          37       37              
  Lines        1675     1679       +4     
==========================================
+ Hits         1448     1450       +2     
- Misses        227      229       +2     
Files Coverage Δ
valentine/algorithms/coma/coma.py 85.13% <66.66%> (-2.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kPsarakis kPsarakis merged commit 057aec8 into master Nov 9, 2023
16 of 19 checks passed
@kPsarakis kPsarakis deleted the java-errors-coma branch May 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant