[ISSUE-1057] bugfix upgrade go 1.21. #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrzej-Zukowski
force-pushed
the
bugfix-upgrade-go-1.21
branch
from
9b2014b to
b133764
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
=======================================
Coverage 72.76% 72.76%
=======================================
Files 63 63
Lines 8949 8949
=======================================
Hits 6512 6512
Misses 2147 2147
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Andrzej-Zukowski
force-pushed
the
bugfix-upgrade-go-1.21
branch
from
698330e to
2944421
Compare
Signed-off-by: Andrzej Zukowski <[email protected]>
Andrzej-Zukowski
force-pushed
the
bugfix-upgrade-go-1.21
branch
from
37e8a27 to
1b4263d
Compare
libzhang
reviewed
Nov 10, 2023
.github/workflows/e2e.yml
Outdated
| @@ -8,7 +8,7 @@ on: | |||
|
|
|||
| env: | |||
| REGISTRY: 'ghcr.io/dell/csi-baremetal' | |||
| go_version: '1.19.2' | |||
| go_version: '1.21.3' | |||
| golangci_version: '1.48.0' | |||
There was a problem hiding this comment.
I see other golangci-lint version changed to 1.55.2, should we also change this together?
|
please also change the PR title to [ISSUE-1057] bugfix upgrade go 1.21. |
libzhang
reviewed
Nov 10, 2023
| GO_VERSION ?= 1.19.10 | ||
| GOLANGCI_VERSION ?= 1.48.0 | ||
| GO_VERSION ?= 1.21.3 | ||
| GOLANGCI_VERSION ?= 1.55.2 |
There was a problem hiding this comment.
devkit change need to pass the multiple jenkins job, (csi-build, csi-kind-acceptance, csi-ci), as these tests are based on the devkit image.
There was a problem hiding this comment.
csi-build - PASSEDcsi-kind-acceptance, csi-ci
Andrzej-Zukowski
changed the title
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Signed-off-by: Andrzej Zukowski <[email protected]>
Andrzej-Zukowski
force-pushed
the
bugfix-upgrade-go-1.21
branch
from
1b4263d to
3a40545
Compare
libzhang
approved these changes
Nov 13, 2023
katarzyna-kulpa
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1057 (#1057)
Library upgrades and base images
PR checklist
Testing
Full regression tests