doc & test cleanup

delta-io · Jan 17, 2025 · 9b170fb · 9b170fb
1 parent 537190a
commit 9b170fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/kernel/src/log_segment.rs b/kernel/src/log_segment.rs
@@ -339,7 +339,7 @@ fn list_log_files_with_version(
                 .find(|(num_parts, part_files)| part_files.len() == *num_parts as usize)
             {
                 checkpoint_parts = complete_checkpoint;
-                commit_files.clear(); // Clear commits when a complete checkpoint is found
+                commit_files.clear(); // Log replay only uses commits after a complete checkpoint
             }
         }
         (commit_files, checkpoint_parts)

diff --git a/kernel/src/log_segment/tests.rs b/kernel/src/log_segment/tests.rs
@@ -142,13 +142,13 @@ fn build_snapshot_with_multiple_incomplete_multipart_checkpoints() {
         &[
             delta_path_for_version(0, "json"),
             delta_path_for_multipart_checkpoint(1, 1, 3),
-            // Part 2 is missing!
+            // Part 2 of 3 at version 1 is missing!
             delta_path_for_multipart_checkpoint(3, 3, 3),
-            // Part 1 is missing!
             delta_path_for_multipart_checkpoint(2, 1, 2),
+            // Part 2 of 2 at version 2 is missing!
             delta_path_for_version(2, "json"),
             delta_path_for_multipart_checkpoint(3, 1, 3),
-            // Part 2 is missing!
+            // Part 2 of 3 at version 3 is missing!
             delta_path_for_multipart_checkpoint(3, 3, 3),
             delta_path_for_multipart_checkpoint(3, 1, 4),
             delta_path_for_multipart_checkpoint(3, 2, 4),
@@ -276,7 +276,7 @@ fn build_snapshot_with_missing_checkpoint_part_from_hint_fails() {
             delta_path_for_version(3, "json"),
             delta_path_for_version(4, "json"),
             delta_path_for_multipart_checkpoint(5, 1, 3),
-            // Part 2 is missing!
+            // Part 2 of 3 at version 5 is missing!
             delta_path_for_multipart_checkpoint(5, 3, 3),
             delta_path_for_version(5, "json"),
             delta_path_for_version(6, "json"),
@@ -338,7 +338,7 @@ fn build_snapshot_with_missing_checkpoint_part_no_hint() {
             delta_path_for_version(3, "json"),
             delta_path_for_version(4, "json"),
             delta_path_for_multipart_checkpoint(5, 1, 3),
-            // Part 2 is missing!
+            // Part 2 of 3 at version 5 is missing!
             delta_path_for_multipart_checkpoint(5, 3, 3),
             delta_path_for_version(5, "json"),
             delta_path_for_version(6, "json"),
@@ -383,7 +383,7 @@ fn build_snapshot_with_out_of_date_last_checkpoint_and_incomplete_recent_checkpo
             delta_path_for_version(3, "checkpoint.parquet"),
             delta_path_for_version(4, "json"),
             delta_path_for_multipart_checkpoint(5, 1, 3),
-            // Part 2 is missing!
+            // Part 2 of 3 at version 5 is missing!
             delta_path_for_multipart_checkpoint(5, 3, 3),
             delta_path_for_version(5, "json"),
             delta_path_for_version(6, "json"),