App Picker #2499
App Picker #2499
Conversation
zeitschlag
force-pushed
the
2450-app-picker
branch
from
0a81e46 to
81221b2
Compare
|
pretty cool already! |
zeitschlag
force-pushed
the
2450-app-picker
branch
3 times, most recently
from
f01553c to
a51dc8a
Compare
# Conflicts: # deltachat-ios/Chat/ChatViewController.swift
zeitschlag
force-pushed
the
2450-app-picker
branch
from
471f451 to
d32380d
Compare
| let appPicker = AppPickerViewController() | ||
| appPicker.delegate = self | ||
| let navigationController = UINavigationController(rootViewController: appPicker) | ||
| navigationController.isModalInPresentation = true |
There was a problem hiding this comment.
I really dislike that you can't dismiss this interactively. It makes sense during download but not really any other time.
There was a problem hiding this comment.
you mean "swipe down to close"? idk, "files" and "gallery" have the same behavior, therefore i thought not too much about it. if it is an easy change, however, of couse, i would not be against having the same behavior as our contact or profile-switcher :)
There was a problem hiding this comment.
Hmmm, that is actually an unintended side effect of the first responder fixes I did and did not notice :/
There was a problem hiding this comment.
I attempted to fix that today in many different ways but I could not figure out how to do it without swizzling. I have a PR in draft that is working with swizzled methods. #2536
Adds an App Picker to download apps from webxdc.org/apps. It works like this:
It looks like this
Consider keyboardIt's a mess due to webview (or I'm incompetent), so I'll leave this for now as it is.Closes #2450
eventually