Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show apps-tab #2529

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Always show apps-tab #2529

merged 3 commits into from
Jan 17, 2025
+19 −46

Conversation

zeitschlag
Copy link
Collaborator

Closes #2526

@zeitschlag zeitschlag requested a review from r10s January 17, 2025 10:54
@zeitschlag zeitschlag self-assigned this Jan 17, 2025
r10s
r10s reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DcContext.hasWebxdc() should be removed as well, and the conditions that were using it evaluated to true.

note sure if there is even more

@zeitschlag zeitschlag requested a review from r10s January 17, 2025 12:30
@zeitschlag zeitschlag merged commit 5c18301 into main Jan 17, 2025
2 checks passed
@zeitschlag zeitschlag deleted the 2526-show-apps branch January 17, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees

@zeitschlag zeitschlag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop hiding "Apps"
2 participants
@zeitschlag @r10s