Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples/viewer): add --output flag to extract eszip to dir #202

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(examples/viewer): add --output flag to extract eszip to dir #202

merged 1 commit into from
Oct 22, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Oct 22, 2024 •
edited
Loading

This PR introduces a flag --output to extract the eszip into a directory of files for easy navigation and readability of source code.

Usage:
  viewer <eszip_path>
  viewer --output <output_dir> <eszip_path>
  viewer -o <output_dir> <eszip_path>

magurotuna
magurotuna approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@satyarohith satyarohith merged commit e6f7ea8 into main Oct 22, 2024
3 checks passed
@satyarohith satyarohith deleted the add_output_flag_to_viewer branch October 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satyarohith @magurotuna