Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add misc parse() test cases #5188

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 28, 2024

This PR adds misc test cases to exercises the edge cases of parse. The line coverage of readDocument becomes 100% with this change.

part of #3713

@github-actions github-actions bot added the yaml label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (fa48bea) to head (d7e309e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5188      +/-   ##
==========================================
+ Coverage   94.04%   94.15%   +0.10%     
==========================================
  Files         468      468              
  Lines       37873    37873              
  Branches     5461     5469       +8     
==========================================
+ Hits        35617    35658      +41     
+ Misses       2216     2176      -40     
+ Partials       40       39       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title test(yaml): add misc parse test cases test(yaml): add misc parse() test cases Jun 28, 2024
@kt3k kt3k merged commit 26914ff into denoland:main Jun 28, 2024
16 checks passed
@kt3k kt3k deleted the test-add-misc-cases branch June 28, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants