-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): release [email protected]
#5212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment on the docs for parseArgs
:
On the two paragraphs starting here
By default, the flags module tries to determine the type of all arguments automatically and the return type of the parseArgs method will have an index signature with any as value ({ [x: string]: any }).
If the string, boolean or collect option is set, the return value of the parseArgs method will be fully typed and the index signature of the return type will change to { [x: string]: unknown }.
It refers to the "flags" module, which is incorrect, and it should probably use "this function" instead of "the parseArgs method"
Done in #5458 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To be released July 18.
The latest API docs: https://jsr.io/@std/[email protected]/doc
Closes #5002