Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): release [email protected] #5212

Merged
merged 6 commits into from
Jul 19, 2024
Merged

chore(cli): release [email protected] #5212

merged 6 commits into from
Jul 19, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 1, 2024

To be released July 18.

The latest API docs: https://jsr.io/@std/[email protected]/doc

Closes #5002

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 03:44
@github-actions github-actions bot added the cli label Jul 1, 2024
@kt3k kt3k requested a review from nathanwhit July 16, 2024 14:48
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment on the docs for parseArgs:

On the two paragraphs starting here

By default, the flags module tries to determine the type of all arguments automatically and the return type of the parseArgs method will have an index signature with any as value ({ [x: string]: any }).

If the string, boolean or collect option is set, the return value of the parseArgs method will be fully typed and the index signature of the return type will change to { [x: string]: unknown }.

It refers to the "flags" module, which is incorrect, and it should probably use "this function" instead of "the parseArgs method"

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 16, 2024

LGTM, just one minor comment on the docs for parseArgs:

On the two paragraphs starting here

By default, the flags module tries to determine the type of all arguments automatically and the return type of the parseArgs method will have an index signature with any as value ({ [x: string]: any }).
If the string, boolean or collect option is set, the return value of the parseArgs method will be fully typed and the index signature of the return type will change to { [x: string]: unknown }.

It refers to the "flags" module, which is incorrect, and it should probably use "this function" instead of "the parseArgs method"

Done in #5458

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from async-1 to main July 19, 2024 03:19
@iuioiua iuioiua enabled auto-merge (squash) July 19, 2024 03:21
@iuioiua iuioiua merged commit e6c05c6 into main Jul 19, 2024
14 checks passed
@iuioiua iuioiua deleted the cli-1 branch July 19, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants