chore: fix regex to match mod.ts files (#6330) #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6331 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 547 547
Lines 41788 41788
Branches 6341 6341
=======================================
Hits 40297 40297
Misses 1450 1450
Partials 41 41 ☔ View full report in Codecov by Sentry. |
jbronder
changed the title
kt3k
changed the title
kt3k
reviewed
Jan 6, 2025
|
Oh yeah, I missed the double backslash. Thank you for looking it over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #6330. A change to the
matchproperty is proposed such that onlymod.tsfiles are checked in the lint task ofdeno task lint:mod-exports. This change is intended to prevent including files that are notmod.tsfiles, but for the purposes of naming files (e.g.unstable_chmod.ts) which happen to end with a*mod.tsin the file name.