This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Added Private Route Array #69
Open
gaokevin1
wants to merge
13
commits into
main
Choose a base branch
from
add-private-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafshen
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, need to think about the combination of both Public routes and private routes
asafshen
reviewed
Jul 23, 2024
@gaokevin1 we also need to add this to the sdk readme |
asafshen
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool 👍
some comments
Co-authored-by: Asaf Shen <[email protected]>
Co-authored-by: Asaf Shen <[email protected]>
Co-authored-by: Asaf Shen <[email protected]>
Co-authored-by: Asaf Shen <[email protected]>
asafshen
reviewed
Jul 27, 2024
Co-authored-by: Asaf Shen <[email protected]>
Co-authored-by: Asaf Shen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related PRs
Description
For apps that are simple and require most routes to be public and have a few strictly defined
private
routes, this change will make every route public by default, ifprivateRoutes
is defined. The routes defined in the array will therefore be protected instead.Essentially the opposite of the
publicRoutes
array in themiddleware.ts
.Must