Skip to content

Commit

Permalink
added matrix strategy for phpunit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
gaokevin1 committed Jan 2, 2025
1 parent ba71e2d commit 134de0e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/phpunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ jobs:
env:
DESCOPE_PROJECT_ID: ${{ vars.DESCOPE_PROJECT_ID }}

strategy:
matrix:
php-version: [8.1, 7.3]

steps:
- uses: actions/checkout@v2

- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.0'
php-version: ${{ matrix.php-version }}

- name: Install dependencies
run: composer install
Expand Down
2 changes: 1 addition & 1 deletion sample/callback.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
error_log("Session token verification failed.");
$descopeSDK->logout();
// Redirect to login page
// header('Location: login.php');
header('Location: login.php');
exit();
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion sample/login.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function sendFormData(sessionToken, userDetails) {
sdk.logout();
console.log("No valid refresh token. Displaying login form.");
const container = document.getElementById("container")
container.innerHTML = '<descope-wc project-id="' + projectId + '" flow-id="test"></descope-wc>';
container.innerHTML = '<descope-wc project-id="' + projectId + '" flow-id="sign-up-or-in"></descope-wc>';
const wcElement = document.getElementsByTagName('descope-wc')[0];
const onSuccess = async (e) => {
Expand Down
2 changes: 1 addition & 1 deletion src/tests/Management/UserPwdTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function testUserPasswordDjango()

public function testUserPasswordMD5()
{
$md5Hash = 'pbkdf2_sha256$30000$hashvalue';
$md5Hash = '87f77988ccb5aa917c93201ba314fcd4';
$userPasswordMD5 = new UserPasswordMD5($md5Hash);
$expectedArray = [
'md5' => [
Expand Down

0 comments on commit 134de0e

Please sign in to comment.