cleaned up code

descope · Dec 27, 2024 · 1ac0689 · 1ac0689
1 parent e2ea284
commit 1ac0689
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/SDK/Management/Role.php b/src/SDK/Management/Role.php
@@ -29,8 +29,10 @@ public function __construct(API $api)
      * @return bool True if tenant permissions are valid, false otherwise.
      * @throws AuthException If JWT response is invalid.
      */
-    public function validateTenantPermissions(array $jwtResponse, string $tenant = '', array $permissions): bool
+    public function validateTenantPermissions(array $jwtResponse, array $permissions, ?string $tenant = null): bool
     {
+        $tenant = $tenant ?? '';
+
         if (!is_array($permissions)) {
             $permissions = [$permissions];
         }

diff --git a/src/tests/DescopeSDKTest.php b/src/tests/DescopeSDKTest.php
@@ -1,11 +1,15 @@
 <?php
 
+namespace Descope\Tests;
+
 use PHPUnit\Framework\TestCase;
 use Descope\SDK\DescopeSDK;
 use Descope\SDK\API;
-use Descope\SDK\Configuration\SDKConfig;
+use Descope\SDK\Auth\Password;
+use Descope\SDK\Auth\SSO;
+use Descope\SDK\Management\Management;
 
-class DescopeSDKTest extends TestCase
+final class DescopeSDKTest extends TestCase
 {
     private $config;
     private $sdk;
@@ -21,9 +25,9 @@ protected function setUp(): void
 
     public function testConstructorInitializesComponents()
     {
-        $this->assertInstanceOf(SDKConfig::class, $this->sdk->password());
-        $this->assertInstanceOf(SDKConfig::class, $this->sdk->sso());
-        $this->assertInstanceOf(SDKConfig::class, $this->sdk->management());
+        $this->assertInstanceOf(Password::class, $this->sdk->password());
+        $this->assertInstanceOf(SSO::class, $this->sdk->sso());
+        $this->assertInstanceOf(Management::class, $this->sdk->management());
     }
 
     public function testVerifyThrowsExceptionWithoutToken()

diff --git a/src/tests/Management/UserTest.php b/src/tests/Management/UserTest.php
@@ -6,9 +6,6 @@
 use Descope\SDK\DescopeSDK;
 use Descope\SDK\Management\Password\UserPassword;
 use Descope\SDK\Management\Password\UserPasswordBcrypt;
-use Descope\SDK\Management\Password\UserPasswordFirebase;
-use Descope\SDK\Management\Password\UserPasswordPbkdf2;
-use Descope\SDK\Management\Password\UserPasswordDjango;
 use Descope\SDK\Management\User;
 use Descope\SDK\Management\AssociatedTenant;
 use Descope\SDK\Management\UserObj;