Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed Function Definitions and Access Modifiers #31

Merged
merged 21 commits into from
Nov 1, 2024
Merged

Conversation

gaokevin1
Copy link
Member

Related Issues

Related PRs

Description

Fixes the access modifiers as well as function definitions in the SDK.

Must

  • Tests
  • Documentation (if applicable)

@gaokevin1 gaokevin1 requested review from Bars92 and gshriki October 28, 2024 01:16
sample/dashboard.php Outdated Show resolved Hide resolved
gshriki
gshriki previously approved these changes Oct 28, 2024
Copy link
Member

@gshriki gshriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments.
Mostly concerned about backward compat. on few changes.

src/SDK/API.php Outdated Show resolved Hide resolved
src/SDK/DescopeSDK.php Show resolved Hide resolved
src/SDK/Management/MgmtV1.php Show resolved Hide resolved
@gaokevin1 gaokevin1 enabled auto-merge (squash) October 31, 2024 16:27
@gaokevin1 gaokevin1 requested a review from gshriki October 31, 2024 16:28
@gaokevin1
Copy link
Member Author

@gshriki can you please approve again.

@gaokevin1 gaokevin1 merged commit bf29968 into main Nov 1, 2024
2 checks passed
@gaokevin1 gaokevin1 deleted the fixes-10-21 branch November 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants