-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added JWK Caching and Support for Laravel 11 #32
Conversation
Maybe I missed - but where are we caching the JWK itself so it is not fetched on every request? adding @omercnet to review as well |
it's cached only in the same verification attempt, see https://github.com/descope/descope-php/pull/32/files#diff-a47473cebf5ae187c13efe92b1fec1ab8ca735408b5a393de87a85ade0174312R73-R111 if we want to cache the jwks between requests need to use APCu or Memcached, depends on what's enabled by the end user |
Co-authored-by: Omer Cohen <[email protected]>
…x-validateToken
…e-php into fix-validateToken
I feel like the best option is to use APCu by default (since it's supported by Laravel as well) and then build some LaravelCache class that will instead use the built-in Laravel caching for Laravel apps, all within the same SDK. Then the customer could just decide which one to use in the initialization of the SDKConfig. Wdyt @omercnet ? |
if you could put in an abstract class with default implementation for acpu that'd be great |
Related Issues
Fixes https://github.com/descope/etc/issues/7756
Related PRs
Description
Added the following items to the PHP SDK:
Must