Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Repeated Helm Deployments #169

Merged

Conversation

mcquinne
Copy link
Contributor

A simple quality of life change: Using helm upgrade --install allows make deploy to be run multiple times as changes are made locally.

What I am changing

  • Using helm install in the makefile prevents one from running make deploy multiple times (helm install fails if the release already exists)
  • This makes it difficult to iterate or experiment locally, e.g. to tweak envVars or add to initdb-data

How I did it

How you can test it

  • Run make deploy or make minikube to install the system into a k8s cluster
  • Make a local change, e.g. update an envVar in #helm-chart/values.yaml
  • Run make deploy or make minikube again
  • The resources of the helm release should be updated without error

Related Issues

  • N/A

Using `helm upgrade --install` allows `make deploy` to be run multiple times as changes are made locally
@ividito ividito merged commit 5a6f2ab into developmentseed:main Jan 2, 2025
3 checks passed
@mcquinne mcquinne deleted the chore/deploy-with-upgrade branch January 7, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants