fix: Increase amount of opened files #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Gulyy <[email protected]>
AObuchow
reviewed
Nov 1, 2023
universal/ubi8/Dockerfile
Outdated
| # default_ulimits = [ | ||
| # "nofile=65535:65535", | ||
| # ] | ||
| RUN (echo '[containers]'; echo 'default_ulimits = ['; echo ' "nofile=65535:65535",'; echo ']') >> /etc/containers/containers.conf |
There was a problem hiding this comment.
This seems good to me, but could also be done with a COPY directive (though you might also have to include a chown as is done here)
There was a problem hiding this comment.
Done. Could you take a look again?
Signed-off-by: Vitaliy Gulyy <[email protected]>
amisevsk
approved these changes
Nov 1, 2023
AObuchow
approved these changes
Nov 1, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, AObuchow, vitaliy-guliy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pjos
pushed a commit
to pjos/developer-images
that referenced
this pull request
Nov 3, 2023
Add configuration to increase amount of opened files Signed-off-by: Vitaliy Gulyy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates
/etc/containers/containers.confconfiguration file to increase amount of opened files forpodman build / podman runRequired for eclipse-che/che#22292