Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a common entrypoint for base and udi, fix .config ownership for podman 5 #209

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

cgruver
Copy link
Contributor

@cgruver cgruver commented Dec 17, 2024

Opened to supersede of #208

This is a fix for - eclipse-che/che#23281

This also fixes the ownership of ~/.config to prevent podman 5+ errors

incorporate changes from 74af9a2

base/ubi9/entrypoint.sh Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgruver, dkwon17

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17
Copy link
Collaborator

dkwon17 commented Dec 18, 2024

Thank you @cgruver , I plan to squash and merge after verifying the PR locally

@dkwon17 dkwon17 merged commit 95dc8de into devfile:main Dec 18, 2024
1 of 2 checks passed
dkwon17 added a commit to dkwon17/devspaces-images that referenced this pull request Dec 19, 2024
@cgruver cgruver deleted the entrypoint-fix branch December 19, 2024 13:09
dkwon17 added a commit to dkwon17/devspaces-images that referenced this pull request Dec 19, 2024
dkwon17 added a commit to redhat-developer/devspaces-images that referenced this pull request Dec 20, 2024
dkwon17 added a commit to redhat-developer/devspaces-images that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants