Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Multi-arch for oci-registry #242

Merged
merged 1 commit into from
May 29, 2024

Conversation

Jdubrick
Copy link
Contributor

Please specify the area for this PR
Bug fix
What does does this PR do / why we need it:
This PR corrects an error in the shell script when dealing with the docker manifest. This is resulting in the image push failing.
Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <[email protected]>
@openshift-ci openshift-ci bot requested a review from elsony May 28, 2024 20:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm very interesting. I'm sure I was able to push the manifest when I was initially testing the PR

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 3777d82 into devfile:main May 29, 2024
8 checks passed
thepetk pushed a commit to thepetk/devfile-registry-support that referenced this pull request May 31, 2024
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: thepetk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants