Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: clickhouse (original, plain) #2337

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

weh
Copy link
Contributor

@weh weh commented Jan 21, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #1195

Link to prove your SVG is correct and up-to-date.

https://clickhouse.com/legal/trademark-policy

@weh weh added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 21, 2025
@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team January 21, 2025 16:34
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal
Copy link
Member

Excellent stuff.

No issues with MR and the icons look great.

image

@canaleal canaleal merged commit 1ad7af3 into devicons:develop Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants