registries: Add tests for Unauthorized Operation #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2024 15:49
vatsa287
reviewed
Dec 20, 2024
pallets/registries/src/tests.rs
Outdated
|
|
||
| // delegate has ADMIN permission and not ASSERT | ||
| assert_err!( | ||
| Registries::ensure_authorization_origin(&delegator_id, &delegate), |
There was a problem hiding this comment.
Shouldn't this be delegate_authorization_id?
pallets/registries/src/tests.rs
Outdated
| &[®istry_id.encode()[..], &delegate.encode()[..], &creator.encode()[..]].concat()[..], | ||
| ); | ||
|
|
||
| let delegator_id: AuthorizationIdOf = generate_authorization_id::<Test>(&delegator_id_digest); |
There was a problem hiding this comment.
Naming this as delegate_auth_id would be more readable, as this belongs to a delegate and not to a delegator.
Similar to other places as well.
Delegator is the one who will delegate others.
|
one more file with conflict :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #535