Add test for PeerIdTooLong and clean up code

[HasanZaigam]

PR Title:

Add Test for PeerIdTooLong Error and Clean Up Code in Network Authorization Pallet

---

Description:

This PR enhances the pallet-network-authorization module by adding tests for the PeerIdTooLong error scenario and refactoring the code to improve readability and maintainability.

Approach:

1. Test for PeerIdTooLong Error: A test case is added to ensure that when a peer ID exceeds 64 bytes, it triggers the PeerIdTooLong error, validating the correct error handling.
2. Successful Authorization Test: Another test ensures that a valid peer ID (64 bytes) is correctly authorized, confirming the function works as expected for valid inputs.
3. Code Cleanup: Removed commented-out code to improve clarity and maintainability. The mock environment setup was also simplified.

Why This Matters:

• Better Test Coverage: This PR ensures edge cases are covered, specifically for error handling related to peer ID validation.
• Code Quality: Cleaning up commented code improves readability, making the codebase more maintainable.
• Consistency: These changes ensure the pallet behaves consistently when handling valid and invalid peer IDs.

---

How to Test:

To run the tests, use the following command:

cargo test -p pallet-network-authorization -- --nocapture

This will verify that the error handling and successful authorization logic are working correctly.

---

By merging this PR, the code becomes more robust and easier to maintain, while laying the foundation for additional tests in the future.

[vatsa287]

@HasanZaigam
The test PeerIdTooLong belongs to node-authorisation module.
There is already a stale PR on this, refer it and re-comit it.
#499

[HasanZaigam]

Hi @vatsa287, I am confused now about what I have to do. Please tell me, if possible, if you can take a Google Meet. I didn't understand what I had to do next.

[Hasan2k5]

Looks good overall! The function is clear, and the length check for peer_id is well-implemented. Just noticed some minor indentation issues—fixing that would make it more readable. Nice work!

[vatsa287]

@HasanZaigam @Hasan2k5
You can ping me on discord vatsa_dhiway, for more clarifications.

[vatsa287]

Changes made here is not required as well.

[vatsa287]

This change is not required as it is the last statement in the block in Rust.

[HasanZaigam]

I have made all the changes and improved the test.rs code to make the test for PeerIdTooLong more comprehensive, as per your guidance. Please review it again, sir.

[HasanZaigam]

@vatsa287, please check the changes and let me know , what next changes I have to make in it, please guide me .

[vatsa287]

@HasanZaigam
All other changes other than tests.rs is not required.

[vatsa287]

@HasanZaigam All other changes other than tests.rs is not required.

@HasanZaigam ^^

[HasanZaigam]

ok , i makes all changes write and add the test case in test only and let you know, after making the changes.

[HasanZaigam]

@vatsa287 makes the changes please review it