Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree_generator: replace - with _ for tree node parameters in .json file #8

Merged
merged 1 commit into from
May 22, 2017

Conversation

angeltop
Copy link

tree_generator behavior is as expected, tree node execution is the desired one. One minor bug found in the creation of .json files, where "-" was not replaced with "_". This is the fix. Thank you Diogo and I apologize for the delay. :)

@diogoalmeida diogoalmeida self-assigned this May 22, 2017
@diogoalmeida
Copy link
Owner

Thanks! I will then merge the changes in the master branch and mark #6 and #7 as solved.

If you do plan to pass more parameters from the keyframes, the changes to the code should be minor, but there will need to be some changes, so please contact me in that eventuality.

@diogoalmeida diogoalmeida merged commit bb0a252 into diogoalmeida:load_parameters May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants