This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Allow conditions to apply to all, except blacklisted entries #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have fixed & updated the failing test. The updated test shows what I believe should happen, if a switch has only one exclusion condition, then it should be active for all things that don't match that condition, and inactive for things that do match it. This allows one to have "default on, but blacklist these condition" switches. |
|
This doesn't seem to make the "not Anonymous" condition work correctly. See my comment in #38 (comment) |
|
Ignore my comment above, it works just fine. See the other comment in #38 (comment) |
added 3 commits
May 20, 2013 12:20
Merge remote-tracking branch 'upstream/master'
Fluxx
added a commit
that referenced
this pull request
Dec 18, 2013
Allow conditions to apply to all, except blacklisted entries
|
I know this is a really old PR and the project doesn't get much attention anymore, but I just wanted to come back to say that this introduces a really nasty bug (raised here #105). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you make a switch "selective" and then add a condition which excludes on thing (e.g. user/ip address) and add no other conditions, then one would assume that the switch will be active for all, except the user/ip address you explicitly blacklisted, and would be false for that user/ip address.
However this is not the case, instead the switch is not active for anyone.
This is from a bug in applying conditions. This patch fixes that.