Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored console-tabs.js #1898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamzap
Copy link
Member

@adamzap adamzap commented Jan 23, 2025

  • Stopped using jQuery
  • Moved refactored code to djangoproject.js

I was also to remove the content showing/hiding functionality that was in the original file because it's handled in CSS. Is there a reason this was in the original JavaScript?

The elements on the right side of the screenshot below are affected by this change:

image

- Stopped using jQuery
- Moved refactored code to `djangoproject.js`

I was also to remove the content show/hide functionality that was in the
original file because it's handled in CSS.
@pauloxnet
Copy link
Member

I was also to remove the content showing/hiding functionality that was in the original file because it's handled in CSS. Is there a reason this was in the original JavaScript?

For me the more JavaScript you can remove in favour of CSS, the better.

@bmispelon
Copy link
Member

Haven't tested it yet, but it looks quite good from the get go (as usual).

Is there a reason this was in the original JavaScript?

I haven't dug in the git history, but I would assume that things got first implemented in javascript, and the js code stuck around when the show/hide behavior was reimplemented in CSS.

Do you have a quick way to test this locally, or does one have to go and build the docs and check there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants