Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #356 - Add support for ref in function literals #357

Merged
merged 1 commit into from Apr 8, 2019
Merged

fix #356 - Add support for ref in function literals #357

merged 1 commit into from Apr 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2019

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #357 into master will increase coverage by 0.56%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   73.59%   74.16%   +0.56%     
==========================================
  Files           8        8              
  Lines        6852     6874      +22     
==========================================
+ Hits         5043     5098      +55     
+ Misses       1809     1776      -33
Impacted Files Coverage Δ
src/dparse/ast.d 49.31% <ø> (+0.45%) ⬆️
src/dparse/formatter.d 25.57% <83.33%> (+2.72%) ⬆️
src/dparse/parser.d 90.77% <93.75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae3719...ea6b61c. Read the comment docs.

src/dparse/parser.d Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 7, 2019

I forgot to update the formatter

@ghost
Copy link
Author

ghost commented Apr 7, 2019

This is good now but unfortunately this PR shows again that #346 is required. For now I just applied a few changes to fix the SEGFAULTs and small errors encountered to support the change to func literals.

@ghost ghost added the auto-merge label Apr 8, 2019
@dlang-bot dlang-bot merged commit 61519b6 into dlang-community:master Apr 8, 2019
@ghost ghost deleted the ref-returns branch May 11, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants