-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always accept .o and .obj files extensions from CLI for all platforms #20609
Conversation
Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20609" |
Don't forget to make this change in dub as well, it does filtering. |
@rikkimax It seems like no changes are needed to DUB: this PR only affects reading of external object files provided by 3rd party build systems (like CMake). If current DUb does things correct it will not need to fix anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea looks okay to me, I just have a comment about the code quality.
Accepting .o and .obj file extensions on all platforms makes DMD behave | ||
the same as Clang and other modern compilers. There is no point in | ||
discarding *.o or *.obj depending on the current OS, as both extensions | ||
indicate that this is an object file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the wording here could be improved. Will come back to this when I am properly awake.
Proposal to discuss
Explanation: ldc-developers/ldc#4733
This patch makes DMD behave the same as clang and maybe all other modern compilers. Seems, there is no point in discarding *.o or *.obj depending on current OS - both extensions point us that this is object file