Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception when checking about:blank response #97

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mildsunrise
Copy link
Contributor

at some point, auth loads about:blank and (since there's no response) an exception occurs:

Traceback (most recent call last):
  File "gp_saml_gui.py", line 127, in on_load_changed
    ct = h.get_content_type()
         ^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get_content_type'

the current code doesn't make much sense -- if an HTTP response is not present, it sets 'h' to None... but then proceeds to do stuff with 'h' assuming it has some value.

the current code doesn't make much sense -- if an
HTTP response is not present, it sets 'h' to None...
but then proceeds to do stuff with 'h' assuming it
has some value.
@dlenski dlenski merged commit c9e7831 into dlenski:master Apr 17, 2024
6 checks passed
@mildsunrise mildsunrise deleted the response-check-exceptions branch April 19, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants