Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core UI schematics #211

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix core UI schematics #211

merged 4 commits into from
Jan 9, 2024

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Jan 8, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The @dlr-eoc/core-ui package used a version of parse5-html-rewriting-stream' which exports the module as default. This caused an undefined import on const { RewritingStream } = await loadEsmModule('parse5-html-rewriting-stream')`

[Module: null prototype] {
  default: [class RewritingStream extends SAXParser]
}

What is the new behavior?

This was fixed by a newer version (v7) of `parse5-html-rewriting-stream',

[Module: null prototype] {
  RewritingStream: [class RewritingStream extends SAXParser]
}

So the import works correctly.


  • In addition, Github workflow actions are updated to use the current node.
  • TUTORIALS.md has been updated to use version placeholders and to add the missing `@clr/icons'.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

  • @dlr-eoc/core-ui

Copy link
Contributor

@lucas-angermann lucas-angermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much for the fix!

@boeckMt boeckMt merged commit 2ade9eb into main Jan 9, 2024
11 checks passed
@boeckMt boeckMt deleted the fix-core-ui-schematics branch January 9, 2024 10:05
@boeckMt boeckMt mentioned this pull request Jan 11, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants