Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow hide popup if functions return false #252

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Dec 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

  • Allow return false for popup.popupFunction and popup.asyncPopup in map-ol service, to not show a popup.

This can be useful to listen on layer click or move to execute a function that does something else with the layer, but does not display a popup.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

  • @dlr-eoc/services-layers:
  • @dlr-eoc/map-ol:

@boeckMt boeckMt requested review from lucas-angermann and removed request for lucas-angermann December 30, 2024 11:26
@boeckMt
Copy link
Member Author

boeckMt commented Dec 30, 2024

FYI @lucas-angermann and @voinSR

@boeckMt boeckMt merged commit b2c0724 into main Dec 30, 2024
3 checks passed
@boeckMt boeckMt deleted the map-ol-popup branch December 30, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant