Skip to content

Commit

Permalink
Add default sql test #1055
Browse files Browse the repository at this point in the history
Signed-off-by: Marcel Coetzee <[email protected]>
  • Loading branch information
Pipboyguy committed Apr 3, 2024
1 parent 8bc3c21 commit 99e82ff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/load/pipeline/test_clickhouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

@pytest.mark.parametrize(
"destination_config",
destinations_configs(all_staging_configs=True, subset=["clickhouse"]),
destinations_configs(default_sql_configs=True, all_staging_configs=True, subset=["clickhouse"]),
ids=lambda x: x.name,
)
def test_clickhouse_destination_append(destination_config: DestinationTestConfiguration) -> None:
Expand Down Expand Up @@ -85,7 +85,7 @@ def items2() -> Iterator[TDataItem]:

@pytest.mark.parametrize(
"destination_config",
destinations_configs(all_staging_configs=True, subset=["clickhouse"]),
destinations_configs(default_sql_configs=True, all_staging_configs=True, subset=["clickhouse"]),
ids=lambda x: x.name,
)
def test_clickhouse_destination_merge(destination_config: DestinationTestConfiguration) -> None:
Expand Down
2 changes: 1 addition & 1 deletion tests/load/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def destinations_configs(
destination_configs += [
DestinationTestConfiguration(destination=destination)
for destination in SQL_DESTINATIONS
if destination not in ("athena", "mssql", "synapse", "databricks", "clickhouse")
if destination not in ("athena", "mssql", "synapse", "databricks")
]
destination_configs += [
DestinationTestConfiguration(destination="duckdb", file_format="parquet")
Expand Down

0 comments on commit 99e82ff

Please sign in to comment.