Feat: parameterize pipeline class in the primary factory method #1176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an easy addition to parameterize and will simplify some hackery in
cdf
. Furthermore it makes the factory method significantly more flexible in possibilities since we can pass subclasses of Pipeline.Related Issues
Additional Context
In the future, it would be even simpler if this sort of factory method was a
classmethod
on thePipeline
class and simply aliased/exported likepipeline = Pipeline.create
wherePipeline.create
has a sig likedef create(cls, ...)
which also lets subclasses benefit from the "standard" setup procedure.For now, we make the simpler change though...