Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: fast postgres to postgres #1428

Merged
merged 25 commits into from
Jun 5, 2024
Merged

Example: fast postgres to postgres #1428

merged 25 commits into from
Jun 5, 2024

Conversation

AstrakhantsevaAA
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA commented May 31, 2024

tested example , fixed bugs, typos and reformatted

  • Created schema example_data_1 in tests Postgres database (which we are using as the destination for ci-cd)
  • Loaded tests data table_1 and table_2
  • Formatted example accordingly CONTRIBUTION.md
  • Tested

Copy link

netlify bot commented May 31, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 88aff7c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/666038696fede900084a0398

@AstrakhantsevaAA AstrakhantsevaAA requested a review from rudolfix June 4, 2024 08:55
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AstrakhantsevaAA this is so good! I think we can radically simplify extension installation. pls see my comments

Makefile Outdated Show resolved Hide resolved
@AstrakhantsevaAA AstrakhantsevaAA requested a review from rudolfix June 5, 2024 10:48
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit e78a3c1 into devel Jun 5, 2024
50 checks passed
@rudolfix rudolfix deleted the example/fast_postgres branch June 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants