Introduce ClassMetadataFactoryInterface to allow switching implementations #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
malarzm
commented
Sep 30, 2023
malarzm
commented
| Q | A |
|---|---|
| Type | bugfix |
| BC Break | fixing one |
| Fixed issues | fixes #2551 |
malarzm
force-pushed
the
gh-2551-cmf-interface
branch
from
bd6d99f to
6c1e90c
Compare
malarzm
force-pushed
the
gh-2551-cmf-interface
branch
2 times, most recently
from
c51a6da to
b1c8e41
Compare
malarzm
commented
Sep 30, 2023
| $metadataFactoryClassName = $this->config->getClassMetadataFactoryName(); | ||
| $this->metadataFactory = new $metadataFactoryClassName(); | ||
| $this->metadataFactory->setDocumentManager($this); | ||
| $this->metadataFactory->setConfiguration($this->config); | ||
| $this->metadataFactory->setProxyClassNameResolver($this->classNameResolver); |
There was a problem hiding this comment.
Rearranging so initialization is done in one place
malarzm
commented
Sep 30, 2023
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| use Attribute; | |||
| use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor; | |||
| use Doctrine\ODM\MongoDB\Mapping\ClassMetadata; | |||
There was a problem hiding this comment.
Unrelated, but phpcbf fixed this automatically
alcaeus
reviewed
Oct 11, 2023
IonBazan
approved these changes
Oct 11, 2023
malarzm
force-pushed
the
gh-2551-cmf-interface
branch
from
b1c8e41 to
7dd5a77
Compare
|
Rebasing as #2553 brought back changes for SA/CS tools to 2.5.x branch. Will work on SA happiness and merge this when CI is green :) |
malarzm
force-pushed
the
gh-2551-cmf-interface
branch
from
7dd5a77 to
fbff519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.