Add processing binary binding type

phpstan-dbal3.neon

@@ -8,11 +8,6 @@ parameters:
         # Symfony cache supports passing a key prefix to the clear method.
         - '/^Method Psr\\Cache\\CacheItemPoolInterface\:\:clear\(\) invoked with 1 parameter, 0 required\.$/'
 
-        # We can be certain that those values are not matched.
-        -
-            message: '~^Match expression does not handle remaining values:~'
-            path: src/Persisters/Entity/BasicEntityPersister.php
-
         # DBAL 4 compatibility
         -
             message: '~^Method Doctrine\\ORM\\Query\\AST\\Functions\\TrimFunction::getTrimMode\(\) never returns .* so it can be removed from the return type\.$~'
@@ -42,10 +37,6 @@ parameters:
             message: '#Expression on left side of \?\? is not nullable.#'
             path: src/Mapping/Driver/AttributeDriver.php
 
-        -
-            message: '~^Method Doctrine\\ORM\\Persisters\\Entity\\BasicEntityPersister\:\:getArrayBindingType\(\) never returns .* so it can be removed from the return type\.$~'
-            path: src/Persisters/Entity/BasicEntityPersister.php
-
         -
             message: '~getTypes.*should return~'
             path: src/Persisters/Entity/BasicEntityPersister.php

phpstan.neon

@@ -7,18 +7,10 @@ parameters:
         # Symfony cache supports passing a key prefix to the clear method.
         - '/^Method Psr\\Cache\\CacheItemPoolInterface\:\:clear\(\) invoked with 1 parameter, 0 required\.$/'
 
-        # We can be certain that those values are not matched.
-        -
-            message: '~^Match expression does not handle remaining values:~'
-            path: src/Persisters/Entity/BasicEntityPersister.php
-
         # DBAL 4 compatibility
         -
             message: '~^Method Doctrine\\ORM\\Query\\AST\\Functions\\TrimFunction::getTrimMode\(\) never returns .* so it can be removed from the return type\.$~'
             path: src/Query/AST/Functions/TrimFunction.php
-        -
-            message: '~^Method Doctrine\\ORM\\Persisters\\Entity\\BasicEntityPersister\:\:getArrayBindingType\(\) never returns .* so it can be removed from the return type\.$~'
-            path: src/Persisters/Entity/BasicEntityPersister.php
 
         # Compatibility with DBAL 3
         # See https://github.com/doctrine/dbal/pull/3480

src/Persisters/Entity/BasicEntityPersister.php

@@ -1,4 +1,4 @@
 <?php
 
 declare(strict_types=1);
 
@@ -10,6 +10,7 @@
 use Doctrine\Common\Collections\Order;
 use Doctrine\DBAL\ArrayParameterType;
 use Doctrine\DBAL\Connection;
+use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\LockMode;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
@@ -1929,17 +1930,24 @@
         return $types;
     }
 
-    /** @phpstan-return ArrayParameterType::* */
-    private function getArrayBindingType(ParameterType|int|string $type): ArrayParameterType|int
+    /**
+     * @psalm-return ArrayParameterType::*
+     *
+     * @throws QueryException
+     * @throws Exception
+     */
+    private function getArrayBindingType(ParameterType|int|string $type): ArrayParameterType
     {
         if (! $type instanceof ParameterType) {
             $type = Type::getType((string) $type)->getBindingType();
         }
 
         return match ($type) {
             ParameterType::STRING => ArrayParameterType::STRING,
             ParameterType::INTEGER => ArrayParameterType::INTEGER,
             ParameterType::ASCII => ArrayParameterType::ASCII,
+            ParameterType::BINARY => ArrayParameterType::BINARY,
+            default => throw new QueryException('Unsupported type for array parameter'),
         };
     }
 

tests/Tests/Models/CMS/CmsUser.php

@@ -29,6 +29,10 @@ class CmsUser
     #[GeneratedValue]
     public $id;
 
+    /** @var string */
+    #[Column(type: 'binary', length: 50, nullable: true)]
+    public $reference;
+
     /** @var string */
     #[Column(type: 'string', length: 50, nullable: true)]
     public $status;

tests/Tests/ORM/Functional/QueryParameterTest.php

@@ -9,8 +9,12 @@
 use Doctrine\DBAL\Types\Types;
 use Doctrine\Tests\Models\CMS\CmsUser;
 use Doctrine\Tests\OrmFunctionalTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 
+use function hex2bin;
+use function sprintf;
+
 #[Group('GH-11278')]
 final class QueryParameterTest extends OrmFunctionalTestCase
 {
@@ -22,15 +26,18 @@ protected function setUp(): void
 
         parent::setUp();
 
-        $user            = new CmsUser();
-        $user->name      = 'John Doe';
-        $user->username  = 'john';
-        $user2           = new CmsUser();
-        $user2->name     = 'Jane Doe';
-        $user2->username = 'jane';
-        $user3           = new CmsUser();
-        $user3->name     = 'Just Bill';
-        $user3->username = 'bill';
+        $user             = new CmsUser();
+        $user->reference  = hex2bin('1');
+        $user->name       = 'John Doe';
+        $user->username   = 'john';
+        $user2            = new CmsUser();
+        $user2->reference = hex2bin('2');
+        $user2->name      = 'Jane Doe';
+        $user2->username  = 'jane';
+        $user3            = new CmsUser();
+        $user3->reference = hex2bin('3');
+        $user3->name      = 'Just Bill';
+        $user3->username  = 'bill';
 
         $this->_em->persist($user);
         $this->_em->persist($user2);
@@ -94,31 +101,27 @@ public function testDbalTypeStringInQuery(): void
         self::assertSame([['name' => 'John Doe']], $result);
     }
 
-    public function testArrayParameterTypeInBuilder(): void
+    #[DataProvider('provideArrayParameters')]
+    public function testArrayParameterTypeInQuery(string $field, ArrayParameterType $type, array $values): void
     {
         $result = $this->_em->createQueryBuilder()
             ->from(CmsUser::class, 'u')
             ->select('u.name')
-            ->where('u.username IN (:usernames)')
-            ->orderBy('u.username')
-            ->setParameter('usernames', ['john', 'jane'], ArrayParameterType::STRING)
+            ->where(sprintf('u.%s IN (:values)', $field))
+            ->orderBy(sprintf('u.%s', $field))
+            ->setParameter('values', $values, $type)
             ->getQuery()
             ->getArrayResult();
 
         self::assertSame([['name' => 'Jane Doe'], ['name' => 'John Doe']], $result);
     }
 
-    public function testArrayParameterTypeInQuery(): void
+    public static function provideArrayParameters(): array
     {
-        $result = $this->_em->createQueryBuilder()
-            ->from(CmsUser::class, 'u')
-            ->select('u.name')
-            ->where('u.username IN (:usernames)')
-            ->orderBy('u.username')
-            ->getQuery()
-            ->setParameter('usernames', ['john', 'jane'], ArrayParameterType::STRING)
-            ->getArrayResult();
-
-        self::assertSame([['name' => 'Jane Doe'], ['name' => 'John Doe']], $result);
+        return [
+            'string' => ['username', ArrayParameterType::STRING, ['john', 'jane']],
+            'binary' => ['reference', ArrayParameterType::BINARY, [hex2bin('1'), hex2bin('2')]],
+            'integer' => ['id' => ArrayParameterType::INTEGER, [1, 2]],
+        ];
     }
 }