[d3d8/9] Proper (and age accurate) handling of d3d9.shaderModel = 0 #4629
+51
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
shadermodel0
branch
4 times, most recently
from
e300bfb to
db884c1
Compare
|
I wasn't expecting any revelations from testing the caps on my GeForce 4 MX 440 card, but apparently I was wrong. Late generations of fixed-function only hardware actually advertised support for VS 1.1 (with no PS support), which makes a lot of sense actually, since games would try to use VS 1.1 anyway, even if we tried to force them to not create programmable shaders of any kind. This PR replicates the above behavior when |
WinterSnowfall
force-pushed
the
shadermodel0
branch
from
db884c1 to
61a9b58
Compare
WinterSnowfall
changed the title
WinterSnowfall
force-pushed
the
shadermodel0
branch
from
61a9b58 to
254e936
Compare
K0bin
requested changes
Jan 21, 2025
WinterSnowfall
force-pushed
the
shadermodel0
branch
from
254e936 to
065c35e
Compare
WinterSnowfall
force-pushed
the
shadermodel0
branch
from
065c35e to
5113fd8
Compare
|
One more nit: turns out the MaxVS/PShaderInstructionsExecuted caps are SM2 (and above) specific and will be zero otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4625 and follows up on an idea I've had in the d8vk days, see AlpyneDreams#208.
Extends D3D7-compatible FF only caps (aka disabling programmable shader support) to D3D8 when using
d3d9.shaderModel = 0, and also validates shader versions on creation in D3D9.Useful for debugging and for nostalgia reasons (with games that do handle such situations properly).