-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/connect options notify #460
base: develop
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
0c043f712767a79a690d42e9fd9f6d89 | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,7 @@ target 'Runner' do | |
end | ||
|
||
# Keep pod path relative so it can be checked into Podfile.lock. | ||
pod 'MultiplatformBleAdapter', :git => 'https://github.com/devVadimAlbul/MultiPlatformBleAdapter.git', :branch => 'feature/connect-options' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will have to be reverted before merging - marking to not forget |
||
pod 'Flutter', :path => 'Flutter' | ||
|
||
# Plugin Pods | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -52,12 +52,19 @@ class Peripheral { | |||||
{bool isAutoConnect = false, | ||||||
int requestMtu = NO_MTU_NEGOTIATION, | ||||||
bool refreshGatt = false, | ||||||
Duration timeout}) => | ||||||
Duration timeout, | ||||||
bool isNotifyOnConnection = false, | ||||||
bool isNotifyOnDisconnection = false, | ||||||
bool isNotifyOnNotification = false}) => | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add dart docs for the new arguments? |
||||||
_manager.connectToPeripheral(identifier, | ||||||
isAutoConnect: isAutoConnect, | ||||||
requestMtu: requestMtu, | ||||||
refreshGatt: refreshGatt, | ||||||
timeout: timeout); | ||||||
timeout: timeout, | ||||||
isNotifyOnConnection: isNotifyOnNotification, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
isNotifyOnDisconnection: isNotifyOnDisconnection, | ||||||
isNotifyOnNotification: isNotifyOnNotification | ||||||
); | ||||||
|
||||||
/// Returns a stream of [PeripheralConnectionState]. | ||||||
/// | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be ignored, I think?