Move user information to auth0 #1023
Conversation
There was a problem hiding this comment.
Didn't we agree on keeping the user table? @henrikhorluck
Make it so the user table is a single column that has the auth0 subject in it? With the current changes it's very possible to lose references because there is no foreign key relations
jotjern
changed the title
| onSubmit: (data) => { | ||
| const result = UserWriteSchema.parse(data) | ||
|
|
||
| if (result.address === "") { | ||
| result.address = undefined |
There was a problem hiding this comment.
| }), | ||
| phone: createTextInput({ | ||
| label: "Telefon", | ||
| placeholder: "12345678", |
There was a problem hiding this comment.
Dette eksempelet er ikke gyldig, og merk at for internasjonale må man ha med +xx
| }), | ||
| lastName: createTextInput({ | ||
| label: "Etternavn", | ||
| placeholder: "Ola", |
| data: [ | ||
| { label: "Mann", value: "male" }, | ||
| { label: "Kvinne", value: "female" }, | ||
| { label: "Annet", value: "other" }, |
There was a problem hiding this comment.
Kan vi ha med "Ønsker ikke svare"?
| label: "Allergier", | ||
| placeholder: "Melk, nøtter, gluten", | ||
| }), | ||
| rfid: createTextInput({ |
There was a problem hiding this comment.
Jeg tror ikke dette er noe vi burde be brukere skrive selv, er litt jobb å dra frem NTNU-kortet, og vi bruker det ikke til noe atm
| @@ -22,7 +22,7 @@ export default function UserDetailsPage() { | |||
| <Box p="md"> | |||
| <Group> | |||
| <CloseButton onClick={() => router.back()} /> | |||
| <Title>{user.name}</Title> | |||
| <Title>{user.firstName || user.lastName ? `${user.firstName} ${user.lastName}` : user.email}</Title> | |||
There was a problem hiding this comment.
Flytt denne logikken til brukeren?
| await core.auth0SynchronizationService.populateUserWithFakeData(token.sub, token.email) // Remove when we have real data | ||
| const user = await core.auth0SynchronizationService.ensureUserLocalDbIsSynced(token.sub, new Date()) | ||
| const user: User | null = await core.userService.getById(token.sub) | ||
| await core.userService.registerId(token.sub) |
There was a problem hiding this comment.
Kan vi ikke bare kun ha getById som registrer selv? API-minimalisering
| getAll(limit: number, page: number): Promise<User[]> | ||
| update(id: UserId, data: Partial<UserWrite>): Promise<User> | ||
| searchForUser(query: string, limit: number, page: number): Promise<User[]> | ||
| createDummyUser(data: UserWrite, password: string): Promise<User> |
There was a problem hiding this comment.
Dette virker 100% test-relatert og burde være i et annet API
| import type { NotificationPermissionsRepository } from "./notification-permissions-repository" | ||
| import type { PrivacyPermissionsRepository } from "./privacy-permissions-repository" | ||
| import type { UserRepository } from "./user-repository" | ||
|
|
||
| export interface UserService { | ||
| getById(id: UserId): Promise<User | null> | ||
| getAll(limit: number): Promise<User[]> | ||
| getAll(limit: number, offset: number): Promise<User[]> | ||
| searchForUser(query: string, limit: number, offset: number): Promise<User[]> |
There was a problem hiding this comment.
Denne burde lenke til auth0 dokumentasjon over støttet syntax
| @@ -254,7 +245,7 @@ export interface PrivacyPermissions { | |||
| phoneVisible: Generated<boolean>; | |||
| profileVisible: Generated<boolean>; | |||
| updatedAt: Generated<Timestamp>; | |||
| userId: string; | |||
| userId: string | null; | |||
There was a problem hiding this comment.
Hvorfor er alle disse satt som | null? Er det ment som on delete set null? Gir mer mening å slette hele privacy-objektet ved sletting/anonymisering.
Merk at vi i ow4 aldri sletter brukere—vi bare anonymiserer.
This pull request does a few things to make it possible to move user data: