Go back to 2017 pool to establish baseline #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamint
pushed a commit
that referenced
this pull request
Sep 24, 2024
Go back to 2017 pool to establish baseline
adamint
pushed a commit
that referenced
this pull request
Sep 24, 2024
Go back to 2017 pool to establish baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving to 2019 we get the following build error:
C:\Program Files\dotnet\sdk\5.0.100-rc.2.20479.15\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(207,5): error NU5128: Some target frameworks declared in the dependencies group of the
nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [G:\NuGet.BuildTasks\src\Microsoft.NuGet.Build.Tasks\Microsoft.NuGet.Build.Tasks.cspro
j]
C:\Program Files\dotnet\sdk\5.0.100-rc.2.20479.15\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(207,5): error NU5128: - Add lib or ref assemblies for the net46 target framework [G:\N
uGet.BuildTasks\src\Microsoft.NuGet.Build.Tasks\Microsoft.NuGet.Build.Tasks.csproj]
##vso[task.logissue type=error;sourcepath=C:\Program Files\dotnet\sdk\5.0.100-rc.2.20479.15\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets;linenumber=207;columnnumber=5;code=NU5128;]Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:%0D%0A- Add lib or ref assemblies for the net46 target framework
Tracked by #91