Fix up relevant CA1416 warnings - Set 4 #26995
Conversation
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
|
@dotnet-policy-service terminate |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| if (OperatingSystem.IsMacCatalystVersionAtLeast(14)) | ||
|
|
||
| // WindowingBehaviors is only available on iOS 16+ and Mac Catalyst | ||
| if (OperatingSystem.IsMacCatalystVersionAtLeast(16) || OperatingSystem.IsIOSVersionAtLeast(16)) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Core/src/Handlers/Application/ApplicationHandler.iOS.cs:51
- [nitpick] The comment should specify that ActivateSceneSession requires iOS 17+ or MacCatalyst 17+ for clarity.
// ActivateSceneSession requires 17+
jfversluis
added
the
area-infrastructure
| @@ -29,6 +29,7 @@ public override void BuildMenu(IUIMenuBuilder builder) | |||
| MenuBuilder = builder; | |||
|
|
|||
| UIWindow? window = null; | |||
|
|
|||
| if (OperatingSystem.IsMacCatalystVersionAtLeast(14)) | |||
There was a problem hiding this comment.
| if (OperatingSystem.IsMacCatalystVersionAtLeast(14)) | |
| if (OperatingSystem.IsMacCatalystVersionAtLeast(14) || OperatingSystem.IsIOSVersionAtLeast(14)) |
| @@ -60,7 +61,9 @@ public override void BuildMenu(IUIMenuBuilder builder) | |||
| } | |||
| } | |||
| else | |||
| { | |||
| window = activeWindowScenes[0].KeyWindow; | |||
There was a problem hiding this comment.
I think here we'll need to add an if statement for "15"
KeyWindow is only available in 15
https://developer.apple.com/documentation/uikit/uiwindowscene/keywindow
So, if it's lower than 15 we'll want to probably check the windows array and return that
https://developer.apple.com/documentation/uikit/uiwindowscene/windows
Description of Change