Remove unnecessary code from extract method #76689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jan 9, 2025
| @@ -173,15 +173,12 @@ await semanticDocument.WithSyntaxRootAsync(result.Root, cancellationToken).Confi | |||
| protected override AbstractFormattingRule GetCustomFormattingRule(Document document) | |||
| => FormattingRule.Instance; | |||
|
|
|||
| protected override SyntaxToken? GetInvocationNameToken(IEnumerable<SyntaxToken> methodNames) | |||
| => methodNames.FirstOrNull(t => !t.Parent.IsKind(SyntaxKind.MethodDeclaration)); | |||
There was a problem hiding this comment.
this code exists from a time when we had multiple tokens annotated, both for the invocation site and the declaration side. this code then filtered down to the one wanted. however, this was changed and we now have a single annotation for this single location. so we can jsut fetch it without needing to do this.
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.