[SwiftBindings] Made AnyType compatible with ISwiftObject #2909
+50
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcumming
approved these changes
Jan 6, 2025
| var metadata = SwiftObjectHelper<AnyType>.GetTypeMetadata(); | ||
| if (!metadata.IsValid) | ||
| { | ||
| throw new InvalidOperationException("Cannot marshal AnyType to Swift without metadata"); |
There was a problem hiding this comment.
Maybe. I put the exceptions in as an afterthought since it looks like this is not an actual valid type because of the lack of a valid TypeMetadata. @kotlarmilos - is AnyType a placeholder for the future since it isn't valid?
There was a problem hiding this comment.
Yes -- it is safe to assume the type is not valid.
rolfbjarne
approved these changes
Jan 7, 2025
kotlarmilos
approved these changes
Jan 8, 2025
| var metadata = SwiftObjectHelper<AnyType>.GetTypeMetadata(); | ||
| if (!metadata.IsValid) | ||
| { | ||
| throw new InvalidOperationException("Cannot marshal AnyType to Swift without metadata"); |
There was a problem hiding this comment.
Yes -- it is safe to assume the type is not valid.
|
This change breaks the compilation: The type or namespace name 'MetadataRequest' could not be found. |
jkurdek
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
SwiftOptional<T>to theSwiftnamespace.Updated the
AnyTypeclass to be compatible with theISwiftObjectinterface.This change adds the methods
NewFromPayloadandMarshalToSwifttoAnyObject.Since the default implementation of GetTypeMetadata returns an invalid metadata, the
MarshalToSwiftmethod throws an exception.Since the default implementation has a payload of
SwiftHandle.Zero, MarshalToSwift throws an exception.