Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR Dont review #4445

Closed
wants to merge 38 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ade004b
WIP WIP WIP
chakaz Dec 5, 2024
ef8f216
jq
chakaz Dec 5, 2024
b057e3c
upload logs
chakaz Dec 5, 2024
7b10f2d
upload all logs
chakaz Dec 5, 2024
5e7d4d7
maybe now
chakaz Dec 5, 2024
4f4350f
path
chakaz Dec 5, 2024
884851f
path2
chakaz Dec 5, 2024
1709dd1
path2
chakaz Dec 5, 2024
c0e266c
release
chakaz Dec 6, 2024
18bf62f
Merge branch 'main' into chakaz/regtests-bullmq
chakaz Dec 22, 2024
c1e5f2e
patch bullmq fixes
chakaz Dec 24, 2024
d931a99
patch force
chakaz Dec 24, 2024
0f40735
Merge branch 'main' into chakaz/regtests-bullmq
chakaz Jan 6, 2025
6469f8f
newer node
chakaz Jan 8, 2025
676c85a
custom release
chakaz Jan 8, 2025
87112dd
v1.24
chakaz Jan 8, 2025
c5ef378
oops
chakaz Jan 8, 2025
76d2ad4
bullmq head
chakaz Jan 8, 2025
216cde1
clean ubuntu, no alpine
chakaz Jan 9, 2025
7ac406f
node
chakaz Jan 9, 2025
455263a
fix
chakaz Jan 9, 2025
22b0f3d
custom node
chakaz Jan 9, 2025
b8b0602
url
chakaz Jan 9, 2025
31a6f66
tar.xv
chakaz Jan 9, 2025
4526103
sudo
chakaz Jan 9, 2025
3c5a475
apt
chakaz Jan 9, 2025
c1ecf65
sudo apt!!
chakaz Jan 9, 2025
7e63e3f
bullmq release
chakaz Jan 9, 2025
b717555
docker
chakaz Jan 9, 2025
7ce26bb
sleep
chakaz Jan 9, 2025
906131e
docker weekly
chakaz Jan 9, 2025
fdce568
Merge branch 'main' into chakaz/regtests-bullmq
chakaz Jan 12, 2025
30ab569
v1.24
chakaz Jan 12, 2025
d1c87ea
no patch
chakaz Jan 12, 2025
7942827
Merge branch 'main' into chakaz/regtests-bullmq
chakaz Jan 26, 2025
39b8c38
TEST FIX
chakaz Jan 26, 2025
2972665
timeout
chakaz Jan 26, 2025
2af98af
no redis-cli
chakaz Jan 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 53 additions & 21 deletions .github/workflows/bullmq-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,39 +12,71 @@ jobs:
name: Build

timeout-minutes: 60
container:
image: ghcr.io/romange/alpine-dev:latest
options: --security-opt seccomp=unconfined
credentials:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
#container:
# image: ghcr.io/romange/alpine-dev:latest
# options: --security-opt seccomp=unconfined
# credentials:
# username: ${{ github.repository_owner }}
# password: ${{ secrets.GITHUB_TOKEN }}
#env:
# node-version: lts/*

services:
dragonflydb:
#image: ghcr.io/dragonflydb/dragonfly-weekly:latest
image: docker.dragonflydb.io/dragonflydb/dragonfly:v1.24.0
env:
DFLY_cluster_mode: emulated
DFLY_lock_on_hashtags: true
HEALTHCHECK_PORT: 6379
ports:
- 6379:6379
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install NodeJs
run: |
apk add --no-cache nodejs npm yarn
wget -q https://unofficial-builds.nodejs.org/download/release/v22.12.0/node-v22.12.0-linux-x64-glibc-217.tar.xz
tar -xf node-v22.12.0-linux-x64-glibc-217.tar.xz
sudo cp -r node-v22.12.0-linux-x64-glibc-217/* /usr/local/
sudo apt install yarn jq
node --version
npm --version
yarn --version
mkdir -p $GITHUB_WORKSPACE/build
- name: Configure/Build
# - name: Configure/Build
# run: |
# cd $GITHUB_WORKSPACE/build
# #cmake .. -DCMAKE_BUILD_TYPE=Release -GNinja
# #ninja dragonfly
# wget -q https://github.com/dragonflydb/dragonfly/releases/download/v1.24.0/dragonfly-x86_64.tar.gz
# tar -zxvf dragonfly-x86_64.tar.gz
# mv dragonfly-x86_64 dragonfly
# ./dragonfly --alsologtostderr --cluster_mode=emulated --lock_on_hashtags --dbfilename= &
- name: Build and Test BullMQ
run: |
cd $GITHUB_WORKSPACE/build
cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja
ninja dragonfly
./dragonfly --alsologtostderr &

- name: Clone and build BullMQ
run: |
git clone https://github.com/taskforcesh/bullmq.git
mkdir -p $GITHUB_WORKSPACE/../bullmq
cd $GITHUB_WORKSPACE/../bullmq
#DOWNLOAD_URL=$(curl -s https://api.github.com/repos/taskforcesh/bullmq/releases/latest | jq -r '.tarball_url')
#echo "Downloading latest BullMQ release from ${DOWNLOAD_URL}"
#wget -q -O bullmq.tar.gz ${DOWNLOAD_URL}
#tar -zxf bullmq.tar.gz
#mv taskforcesh-bullmq-* bullmq
git clone https://github.com/taskforcesh/bullmq
cd bullmq
pwd
yarn install --ignore-engines --frozen-lockfile --non-interactive
#patch -p1 -f < $GITHUB_WORKSPACE/bullmq.patch
yarn install
yarn build
- name: Test BullMQ
run: |
cd $GITHUB_WORKSPACE/bullmq
# yarn test -i -g "should process delayed jobs with several workers respecting delay"
#BULLMQ_TEST_PREFIX={b} yarn test
sed -i 's/timeout: 4000/timeout: 10000/' .mocharc.js
for i in {1..100}; do
BULLMQ_TEST_PREFIX={b} yarn test -g "should keep workers busy";
done
- name: Upload logs on failure
if: failure()
uses: actions/upload-artifact@v4
with:
name: unit_logs
path: /tmp/dragonfly.*
22 changes: 22 additions & 0 deletions bullmq.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/tests/test_job.ts b/tests/test_job.ts
index 0393fe0..57b06d6 100644
--- a/tests/test_job.ts
+++ b/tests/test_job.ts
@@ -1396,6 +1396,8 @@ describe('Job', function () {
expect(isDelayedAfterPromote).to.be.equal(false);
const isCompleted = await job.isCompleted();
expect(isCompleted).to.be.equal(true);
+
+ await worker.close();
});

describe('when re-adding same repeatable job after previous delayed one is promoted', () => {
@@ -1456,6 +1458,8 @@ describe('Job', function () {
const delayedCountAfterReAddition = await queue.getDelayedCount();
expect(completedCountAfterReAddition).to.be.equal(1);
expect(delayedCountAfterReAddition).to.be.equal(1);
+
+ await worker.close();
});
});
});
Loading