Add commit produced by llama3-a6990e #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drawers
commented
May 21, 2024
| @@ -80,7 +80,7 @@ class AdClickAttributionPluginTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun whenFeatureNameMatchesAdClickAttributionThenUpdateAllExistingLists() { | |||
| fun `whenFeatureNameMatchesAdClickAttributionThenUpdateAllExistingLists - update all existing lists`() { | |||
There was a problem hiding this comment.
The function under test has not been inferred correctly here
| @@ -299,7 +299,7 @@ class DuckDuckGoAdClickManagerTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun whenClearTabIdCalledForTabThenRemoveDataForTab() { | |||
| fun `clearTabId - remove data for tab`() { | |||
There was a problem hiding this comment.
Example of model choosing to omit the "state" part of the test convention
drawers
force-pushed
the
target-for-lm-prs
branch
from
5b7db89 to
6cd522d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a diff produced by running our lint fix with llama3-a6990e. To reproduce, check out
target-for-lm-prsand runlintFix --continue