Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type errors in 'RemoteDesktopCollections' and 'RemoteDesktopDeployment' #184

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raandree
Copy link
Collaborator

@raandree raandree commented Sep 12, 2022

Pull Request

Pester tests failed for 'RemoteDesktopCollections' and 'RemoteDesktopDeploymentMade'. 'SessionHost' defined as an array but is a scalar in the underlying DSC resources.

Pull Request (PR) description

Fixed

  • SessionHost is now a scalar in 'RemoteDesktopCollections' and 'RemoteDesktopDeploymentMade'.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@raandree raandree added the bug Something isn't working label Sep 12, 2022
@raandree raandree requested a review from nyanhp September 12, 2022 07:10
@raandree raandree self-assigned this Sep 12, 2022
@nyanhp
Copy link
Contributor

nyanhp commented Sep 15, 2022

Future release of RemoteDesktop DSC resources will support a list of session hosts. I'll convert this PR to a draft until that happens

@raandree raandree marked this pull request as draft September 27, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants