Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 418 v3.0.0 #419

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Feature 418 v3.0.0 #419

merged 7 commits into from
Dec 18, 2024

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METcalcpy-3.0.0 milestone Dec 17, 2024
@bikegeek bikegeek self-assigned this Dec 17, 2024
@bikegeek bikegeek marked this pull request as draft December 17, 2024 22:57
changing date to 18th since GHA are very slow and unlikely to get release done by today
changing date from 17th to 18th, unlikely release will get finished today due to slow GHAs
@jprestop jprestop linked an issue Dec 18, 2024 that may be closed by this pull request
23 tasks
bikegeek and others added 2 commits December 18, 2024 15:21
update version to 1.1.0
Co-authored-by: Julie Prestopnik <[email protected]>
@bikegeek bikegeek marked this pull request as ready for review December 18, 2024 22:45
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this, @bikegeek. I will note that the Python vulnerability checks are failing, but will leave it up to you to decide what to do about that. I approve this request.

@bikegeek bikegeek merged commit 5674017 into main_v3.0 Dec 18, 2024
5 of 7 checks passed
@bikegeek bikegeek deleted the feature_418_v3.0.0 branch December 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the METcalcpy v3.0.0 release
2 participants