Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROC diagram support for reformatted CTC linetype input #424

Closed
22 tasks
bikegeek opened this issue Feb 23, 2024 · 1 comment · Fixed by #427
Closed
22 tasks

ROC diagram support for reformatted CTC linetype input #424

bikegeek opened this issue Feb 23, 2024 · 1 comment · Fixed by #427
Assignees
Labels
component: input data Input data issue priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

Describe the Enhancement

METdataio's reformatter for the CTC linetype produces data that can be used by most plot types. However, the ROC diagram requires explicit columns: fy_oy, fy_on, fn_oy, fn_on, fcst_thresh. These are found under the stat_name and stat_value columns in the file generated by the METdataio reformatter.

Provide capability to read the values from the stat_name and stat_value columns and create additional columns for: fy_oy, fy_on, fn_oy, fn_on, and fcst_thresh but also maintain the ability to read in the CTC data created by METviewer database.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing priority: high High Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project component: input data Input data issue labels Feb 23, 2024
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Feb 23, 2024
@bikegeek bikegeek self-assigned this Feb 23, 2024
bikegeek added a commit that referenced this issue Feb 26, 2024
@bikegeek bikegeek moved this from 🔖 Ready to 🏗 In progress in METplus-Analysis-6.0.0 Development Apr 3, 2024
@jprestop jprestop removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label May 15, 2024
@jprestop jprestop moved this to 🏗 In progress in METplus-Analysis-6.0.0 Development May 15, 2024
@bikegeek bikegeek linked a pull request May 23, 2024 that will close this issue
14 tasks
hankenstein2 pushed a commit that referenced this issue May 29, 2024
* issue #424 add support to read in the reformatted CTC linetype data produced by the METdataio reformatter

* issue #424 remove redundant code that is in the METcalcpy ctc_statistics module

* issue #424 additional data and test for reformatted CTC data

* Issue #424 updates to User's Guide with instructions for METdataio reformatting

* issue #424 added CTC data reformatted from METdataio

* remove unreliable checks

* Added content for the roc_pct and roc_ctc settings in the custom config file.

* Removed unused text
@bikegeek
Copy link
Collaborator Author

bikegeek commented Jun 5, 2024

closing, fixed in #427

@bikegeek bikegeek closed this as completed Jun 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in METplus-Analysis-6.0.0 Development Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: input data Input data issue priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants