Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
generate a ROC diagram using the same data
Instructions:
if running on 'seneca', use this CONDA environment:
/d1/personal/mwin/miniconda3/envs/mp_analysis_env
clone the following code:
- develop branch of METcalcpy
- feature_424_ROC_CTC branch of METplotpy
set up the PYTHONPATH:
- export PYTHONPATH=$CALCPY:$CALCPY/metcalcpy:$PLOTPY:$PLOTPY/metplotpy:$PLOTPY/metplotpy/plots
- $CALCPY and $PLOTPY are env vars pointing to the location of the METcalcpy and METplotpy source, respectively
use this data(remove .txt extension):
This has been reformatted by the METdataio reformatter
wind_only.data.txt
use this custom configuration file (remove .txt extension):
ctc_from_dataio_ROC.yaml.txt
generate the plot:
python $PLOTPY/metplotpy/plots/roc_diagram/roc_diagram.py /path/to/ctc_from_dataio_ROC.yaml
should generate this plot:
NOTE:
This is also set up on 'seneca' under:
/d1/personal/mwin/feature_424_ROC_CTC/
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes ]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by anytime before the beta5 release.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes