issue # 425, make fixes to the contour plot for the Z value to remove…

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  

• testing on seneca

• testing on seneca by Mrinal, following the instructions in the README (see attached README.txt):
  /d1/projects/METplotpy_TC_RMW/README
  README.txt

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

• Do these changes include sufficient testing updates? [Yes or No]

• Will this PR result in changes to the test suite? [Yes or No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[hankenstein2]

I was able to generate the image part of the review successfully but the height_from_pressure piece is throwing an error on the netcdf part
KeyError: 'RH'

Looks like the source netcdf file does not have RH and the code is looking for it

[mrinalbiswas]

@fisherhucar Yes, I also noticed that RH is a required field in height_from_pressure_tcrmw.yaml.

[bikegeek]

The METcalcpy vertical interpolation requires the RH to calculate the mixing ratio, which is used to calculate the virtual temperature, the virtual temperature is used to calculate the layer thickness, which is used to calculate pressure indices. I updated the METcalcpy and METplotpy User's Guides to explicitly state which fields are mandatory.

…

--------------- Minna Win Pronouns: she/her NSF NCAR DTC & Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* ---------------

On Mon, Mar 18, 2024 at 3:38 PM mrinalbiswas ***@***.***> wrote: @fisherhucar <https://github.com/fisherhucar> Yes, I also noticed that RH is a required field in height_from_pressure_tcrmw.yaml. — Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHXS2RFP67DX4BQM5SDYY5NDPAVCNFSM6AAAAABEW5KCHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGA3DQNBUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>